FloatImage: use any kwargs as CSS#1668
Merged
Conengmo merged 1 commit intopython-visualization:mainfrom Nov 29, 2022
Merged
Conversation
ocefpaf
approved these changes
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1667.
We introduced a regression in #1570 by always setting
widthto 100 %. At first I wanted to fix it by making the argument optional. But then, after also checking #1001 again, I opted to just open up the class to any CSS properties. With users being able to apply any CSS, we shouldn't hear about this again.Note that this does mean an API change compared to version 0.13.0, since
widthwill now require a unit like '%' or 'px' instead of just an integer. But I think that's a good thing. I didn't want to mess with thebottomandleftparameters though, because I assume those have been around for much longer.