Conversation
|
I would prefer a PR that makes passing the pre-computed bins so users could use whatever they want. However, that may be too complex and would break a lot of code. With that said, this PR is fine and it makes sense. My only request is to move the import inside the if-clause and add or add try/except clause for it at the top so we cab make it optional. I don't want to increase the number of dependencies in folium. |
|
Of course. To be clear, you want to put the import inside of the if-clause or add a try/except clause, not both, right? |
Conengmo
left a comment
There was a problem hiding this comment.
I like it! Have some comments, could you take a look?
There was a problem hiding this comment.
Could you also include the notebook output in a commit? That way it will show up here: https://nbviewer.org/github/pmains/folium/blob/jenks/examples/Jenks.ipynb
|
Thank you @pmains! Nice addition. |
This feature change adds Jenks Natural Breaks Optimization to choropleths created using Folium.
https://en.wikipedia.org/wiki/Jenks_natural_breaks_optimization