Skip to content

Jenks#1634

Merged
Conengmo merged 8 commits intopython-visualization:mainfrom
pmains:jenks
Nov 17, 2022
Merged

Jenks#1634
Conengmo merged 8 commits intopython-visualization:mainfrom
pmains:jenks

Conversation

@pmains
Copy link
Copy Markdown
Contributor

@pmains pmains commented Oct 13, 2022

This feature change adds Jenks Natural Breaks Optimization to choropleths created using Folium.
https://en.wikipedia.org/wiki/Jenks_natural_breaks_optimization

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented Oct 13, 2022

I would prefer a PR that makes passing the pre-computed bins so users could use whatever they want. However, that may be too complex and would break a lot of code.

With that said, this PR is fine and it makes sense. My only request is to move the import inside the if-clause and add or add try/except clause for it at the top so we cab make it optional. I don't want to increase the number of dependencies in folium.

@pmains
Copy link
Copy Markdown
Contributor Author

pmains commented Oct 13, 2022

Of course.

To be clear, you want to put the import inside of the if-clause or add a try/except clause, not both, right?

Copy link
Copy Markdown
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Have some comments, could you take a look?

Copy link
Copy Markdown
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Conengmo Conengmo added the waiting for changes This PR has been reviewed and changes are needed before merging label Nov 7, 2022
@Conengmo Conengmo added ready PR is ready for merging and removed waiting for changes This PR has been reviewed and changes are needed before merging labels Nov 17, 2022
@Conengmo Conengmo merged commit bd910b4 into python-visualization:main Nov 17, 2022
@Conengmo
Copy link
Copy Markdown
Member

Thank you @pmains! Nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PR is ready for merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants