Skip to content

Allow for simple Popup too#1528

Merged
Conengmo merged 1 commit intopython-visualization:masterfrom
ocefpaf:allow_simple_popup_on_gjson
Nov 16, 2021
Merged

Allow for simple Popup too#1528
Conengmo merged 1 commit intopython-visualization:masterfrom
ocefpaf:allow_simple_popup_on_gjson

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Nov 12, 2021

@Conengmo this used to be default but now it fails silently. This PR just add it back while keep the option for the more advanced GeoJsonPopup.

@Conengmo
Copy link
Member

I should fix those tests... but this PR is good to merge!

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 12, 2021

I should fix those tests... but this PR is good to merge!

I can take a look at those test. Hold on... I also need to fix the versioning thing :-(

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 12, 2021

@Conengmo I did not fix any test yet but I separated them to make it easier to examine and make a decision.
I'll work on the version number next.

@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 15, 2021

@Conengmo are you OK merging this as is for now? I'll take a look at the version issue next and then the selenium failure. But I'm clueless on the latest branca failure there.

@Conengmo
Copy link
Member

Could you split the changes to the tests/releasing into a separate PR? That will make it easier to track what changes we made over time.

@ocefpaf ocefpaf force-pushed the allow_simple_popup_on_gjson branch from f938594 to e3e5d58 Compare November 16, 2021 15:29
@ocefpaf ocefpaf mentioned this pull request Nov 16, 2021
@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 16, 2021

Could you split the changes to the tests/releasing into a separate PR? That will make it easier to track what changes we made over time.

Done! See #1533

@Conengmo Conengmo merged commit d697154 into python-visualization:master Nov 16, 2021
@ocefpaf ocefpaf deleted the allow_simple_popup_on_gjson branch November 16, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants