Remove deprecated tilesets#1339
Merged
Conengmo merged 2 commits intopython-visualization:masterfrom May 30, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up some of the built-in tileset templates.
Cloudmade no longer provides a public API. Our version of the Mapbox API is outdated, see #922
It's quite trivial for users to keep using Mapbox, they just have to pass the API url to the
tilesargument. I reckon that's what current Mapbox users are already doing. So I don't see a need to update our template to v4.We can also drop the
API_keyargument which was only used for Cloudmade and Mapbox.Raise an exception if a users tries to use the removed tilesets, providing help on how to resolve.
Closes #922