Fix empty geojson failing with style_function#1213
Merged
Conengmo merged 5 commits intopython-visualization:mainfrom Nov 15, 2022
Merged
Fix empty geojson failing with style_function#1213Conengmo merged 5 commits intopython-visualization:mainfrom
Conengmo merged 5 commits intopython-visualization:mainfrom
Conversation
stickler-ci
reviewed
Oct 9, 2019
Conengmo
requested changes
Oct 29, 2019
Member
Conengmo
left a comment
There was a problem hiding this comment.
Thanks for briging this bug to our attention. Let's fix it indeed. Could you address my comment and fix the CI comment about the indentation? Please also add a test that shows that using empty geojson data with a style function does not fail.
Conengmo
approved these changes
Nov 10, 2022
Member
Conengmo
left a comment
There was a problem hiding this comment.
This should do it. Let's merge when the tests pass.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, attempting to plot an empty GeoJson object fails if there's a
style_function. This fix checks if there are features first.Closes #1212