Keep map only in png screenshot #1197
Merged
Conengmo merged 8 commits intopython-visualization:mainfrom Nov 15, 2022
Merged
Conversation
Contributor
Author
|
I guess the |
Member
Now you know 😄 The weirdest thing is that they do pass on my Travis-CI instance! Can you revert that change so we can merge this PR? |
Contributor
Author
|
Done :) |
This reverts commit f80da13.
ocefpaf
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we call
m._to_png()we get a sreenshot of the full window, even if the map is smaller. I changed that.I didn't understand why the tests were marked as
xfail. As they pass, I removed the decorator.