chore: feature flag Overlay and ActionMenu max-height viewport clamping#7679
Conversation
|
Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
|
|
@copilot delete primer_react_action_menu_max_height_clamp_to_viewport and use primer_react_overlay_max_height_clamp_to_viewport instead for both implementations |
…verlay_max_height_clamp_to_viewport Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
Done in 65c1434. Removed |
adeb242
into
chore/fix-max-height-attributes
Gates the
min(Xpx, 100dvh)max-height behavior forOverlayandActionMenubehind a single shared feature flag.Changelog
New
primer_react_overlay_max_height_clamp_to_viewport(defaultfalse) inDefaultFeatureFlags.ts— controls viewport-clamped max-height for bothOverlayandActionMenuChanged
Overlay.module.css: max-height size tokens revert to fixed px values; viewport-clamped variants (min(Xpx, 100dvh)) now only apply when[data-max-height-clamp-to-viewport]is presentOverlay.tsx: readsprimer_react_overlay_max_height_clamp_to_viewportand conditionally setsdata-max-height-clamp-to-viewporton the overlay elementActionMenu.tsx: updated to useprimer_react_overlay_max_height_clamp_to_viewport(same shared flag asOverlay)Removed
primer_react_action_menu_max_height_clamp_to_viewportfeature flag — replaced by the sharedprimer_react_overlay_max_height_clamp_to_viewportflagRollout strategy
Testing & Reviewing
Enable
primer_react_overlay_max_height_clamp_to_viewportviaFeatureFlagsand verify that both overlays and action menus with amaxHeightprop clamp correctly against the viewport on narrow screens.Merge checklist
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.