Skip to content

Add primer.fg.white#172

Merged
simurai merged 2 commits intomainfrom
fg-white
Jun 25, 2021
Merged

Add primer.fg.white#172
simurai merged 2 commits intomainfrom
fg-white

Conversation

@simurai
Copy link
Contributor

@simurai simurai commented Jun 25, 2021

This adds a new primer.fg.white variable that is white in all themes. It gets used to map text.white -> primer.fg.white.

This is needed because fg.onEmphasis got changed to dark in HC and causing regressions.

@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2021

🦋 Changeset detected

Latest commit: 2271374

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/3X2aDAKTMaudPZpgZ9U1srCzhmvp
✅ Preview: https://primitives-git-fg-white-primer.vercel.app

@simurai simurai merged commit 1b2f972 into main Jun 25, 2021
@simurai simurai deleted the fg-white branch June 25, 2021 06:17
@github-actions github-actions bot mentioned this pull request Jun 25, 2021
@simurai simurai mentioned this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant