Skip to content

Added canvas subtle#128

Merged
simurai merged 3 commits intomainfrom
auareyou-updates
Jun 9, 2021
Merged

Added canvas subtle#128
simurai merged 3 commits intomainfrom
auareyou-updates

Conversation

@auareyou
Copy link
Contributor

@auareyou auareyou commented Jun 4, 2021

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 4, 2021

🦋 Changeset detected

Latest commit: fe47bf9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/BTHA4uvDJfKUgdvQMuvowhwWazuc
✅ Preview: https://primitives-git-auareyou-updates-primer.vercel.app

@auareyou auareyou requested a review from colebemis June 4, 2021 16:42
@colebemis
Copy link
Contributor

Do you want to update the deprecated variables to map to canvas.subtle instead of neutral.subtle in this PR?

@auareyou
Copy link
Contributor Author

auareyou commented Jun 8, 2021

Do you want to update the deprecated variables to map to canvas.subtle instead of neutral.subtle in this PR?

Ah yes! I'll do that today!

@simurai
Copy link
Contributor

simurai commented Jun 8, 2021

Do you want to update the deprecated variables to map to canvas.subtle instead of neutral.subtle in this PR?

Maybe we can keep neutral.subtle for smaller things like hover state, counters, branch name, but change it for:

  • bg.secondary -> canvas.subtle
  • bg.tertiary -> canvas.subtle
  • timeline.badgeBg -> canvas.subtle (to cover the timeline border)

@auareyou
Copy link
Contributor Author

auareyou commented Jun 8, 2021

Do you want to update the deprecated variables to map to canvas.subtle instead of neutral.subtle in this PR?

Maybe we can keep neutral.subtle for smaller things like hover state, counters, branch name, but change it for:

  • bg.secondary -> canvas.subtle
  • bg.tertiary -> canvas.subtle
  • timeline.badgeBg -> canvas.subtle (to cover the timeline border)

That makes sense! It's a good rule!

@auareyou
Copy link
Contributor Author

auareyou commented Jun 8, 2021

I'd add, neutral subtle is for things that overlap with backgrounds

Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! It's a good rule!

Ok, added it here fe47bf9. Let's test it. 🚢

@simurai simurai merged commit 58178d6 into main Jun 9, 2021
@simurai simurai deleted the auareyou-updates branch June 9, 2021 00:55
@github-actions github-actions bot mentioned this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants