Extend line-height values to better support Linux#1271
Merged
langermank merged 2 commits intomainfrom Nov 10, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 374dc66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Design Token Diff (CSS)
|
Contributor
Design Token Diff (StyleLint)
|
Contributor
Design Token Diff (Figma)
|
Contributor
Design Token Diff (Fallbacks)
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the precision of two body text line-height values from 4 to 5 decimal places to fix rendering issues in VRT tests on Linux.
- Extended
text.body.lineHeight.mediumfrom1.4285to1.42857 - Extended
text.body.lineHeight.smallfrom1.6666to1.66667
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tokens/functional/typography/typography.json5 | Updated line-height precision for medium and small body text sizes |
| .changeset/large-laws-doubt.md | Added changeset documenting the patch-level change |
Comments suppressed due to low confidence (1)
src/tokens/functional/typography/typography.json5:417
- For consistency with the precision improvements made to body.lineHeight values, consider extending this line-height value to 5 decimal places (1.33333). The file also contains text.codeBlock.lineHeight at 1.5385 which could benefit from similar precision treatment if cross-platform rendering consistency is the goal.
$value: 1.3333,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primer's VRT tests run on Linux, and we can see that the line-height is just slightly off. Adding one more digit to the value seems to fix it (tested in dotcom and primer/react)
Dotcom: https://github-a489b1074d-56576033.drafts.github.io/vrt/#?q=s:failed
Primer React: https://primer-29525c1775-13348165.drafts.github.io/vrt/#?q=s:failed