Update control knob border-color values#1239
Merged
langermank merged 3 commits intomainfrom Jul 23, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 0250069 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
...version for `@primer/primitives` in changeset.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the control knob border-color values to align with the design decision to only offer high contrast borders within high contrast themes. The change ensures that default themes use regular border colors while high contrast themes maintain emphasized borders for better accessibility.
- Changed default border-color from
emphasistorestfor regular themes - Added explicit
emphasisborder-color overrides for all high contrast theme variants - Maintained consistency across light and dark high contrast themes including colorblind-friendly variants
Comment on lines
+1296
to
+1302
| 'dark-dimmed-high-contrast': '{control.borderColor.emphasis}', | ||
| 'light-high-contrast': '{control.borderColor.emphasis}', | ||
| 'light-tritanopia-high-contrast': '{control.borderColor.emphasis}', | ||
| 'light-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}', | ||
| 'dark-high-contrast': '{control.borderColor.emphasis}', | ||
| 'dark-tritanopia-high-contrast': '{control.borderColor.emphasis}', | ||
| 'dark-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}', |
There was a problem hiding this comment.
[nitpick] The high contrast theme overrides could be organized alphabetically for better maintainability. Consider grouping light themes first, then dark themes, and within each group sort alphabetically.
Suggested change
| 'dark-dimmed-high-contrast': '{control.borderColor.emphasis}', | |
| 'light-high-contrast': '{control.borderColor.emphasis}', | |
| 'light-tritanopia-high-contrast': '{control.borderColor.emphasis}', | |
| 'light-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}', | |
| 'dark-high-contrast': '{control.borderColor.emphasis}', | |
| 'dark-tritanopia-high-contrast': '{control.borderColor.emphasis}', | |
| 'dark-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}', | |
| 'light-high-contrast': '{control.borderColor.emphasis}', | |
| 'light-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}', | |
| 'light-tritanopia-high-contrast': '{control.borderColor.emphasis}', | |
| 'dark-dimmed-high-contrast': '{control.borderColor.emphasis}', | |
| 'dark-high-contrast': '{control.borderColor.emphasis}', | |
| 'dark-protanopia-deuteranopia-high-contrast': '{control.borderColor.emphasis}', | |
| 'dark-tritanopia-high-contrast': '{control.borderColor.emphasis}', |
Contributor
Design Token Diff (CSS)
|
Contributor
Design Token Diff (StyleLint)
|
Contributor
Design Token Diff (Figma)
|
lukasoppermann
approved these changes
Jul 17, 2025
Collaborator
There was a problem hiding this comment.
@langermank I think the toggle does not look that great because the knob border and outside border is the same.
I think we could either make it look like segmented control and have the border overlap the outside border. Or we could remove it entirely and have no border. But this way looks a big buggy to me.
The other components look great.
Nevermind, if you look at it at 100% and not zoomed in, this is not really noticable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/5466
Updates the
knobborder-color to align with our decision to only offer high contrast borders within high contrast themes.