Handle missing vertexcolor and facecolor in mesh3d#4353
Conversation
|
rename missing vertex color reverts to white, but missing face color is omitted. Is that intentional / desirable? Offhand I'd think we'd want the faces to be white as well. Or perhaps a light gray in both cases... |
|
We could use gray color for both cases which is pretty easy to do. |
|
In general I feel like data should not disappear if some secondary characteristic of it (color in this case, but more generally anything beyond its position) is missing or invalid. For example scatter traces with a short This is mostly useful for debugging, so you can see what parts you got right and what parts have issues. If your goal is to make a transparent face, you should specify this explicitly rather than relying on an implicit "bad data becomes transparent" |
- display mesh3d missing colors gray - update baseline
@alexcjohnson Good call. |
Fix #4348 & #4349
gl-mesh3dused to stop when encountering a missingvertexcolororfacecolorwhich is fixed bygl-mesh3dv2.1.2 and v2.1.3 patches.This PR bumps
gl-mesh3dand adds an image test.@plotly/plotly_js