Conversation
- use `OPPOSITE_SIDE` constants - use `shiftSign` result in `maxshift` computation
... so that we can add other `title.*` to cartesian axes
w/o breaking other subplots
- must now compute `ax._depth` when `standoff` is set to get compute distance - add `approxTitleDepth` helper with backward-compatible "looser" computation when `standoff` isn't set - add two mock: one with axis `automargin:true` and one w/o
... into `Axes.getTickSigns` output
archmoj
reviewed
Oct 22, 2019
Contributor
|
@etpinard My comment above is non-blocking; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4224
This PR adds a new attribute
title.standoffto cartesian axes - which determines the distance (in px) between the tick labels (at max depth) and the axis title.example 1: https://codepen.io/etpinard/pen/LYYZJXw?editors=0010
example 2: https://codepen.io/etpinard/pen/jOOrvdZ?editors=1010
cc @plotly/plotly_js