Skip to content

add missing translation keys#4148

Merged
etpinard merged 2 commits intoplotly:masterfrom
Batalex:support/missing-translations
Sep 23, 2019
Merged

add missing translation keys#4148
etpinard merged 2 commits intoplotly:masterfrom
Batalex:support/missing-translations

Conversation

@Batalex
Copy link
Copy Markdown
Contributor

@Batalex Batalex commented Aug 26, 2019

See #4142

This PR adds the missing "Download plot" localization key for the following languages:

  • cs
  • de
  • es
  • fr
  • it
  • ja
  • pt-br
  • sw

The others languages either have already the missing key or do not translate modebar buttons.
I am by no mean a translator (Deepl/Translate for the win). Native speakers feedbacks are welcome even if it seemed "simple".

@etpinard
Copy link
Copy Markdown
Contributor

@Batalex how well do you know each of the languages you edited?

I can personally approve the fr translation you provided. The de translation seems pretty straight forward too. But I don't think we should trust Deepl/Translate. In other words, I would prefer not translating Download plot at all over adding a translation that no one approved.

@etpinard
Copy link
Copy Markdown
Contributor

Pinging people that could potentially help us out:

@fhurta @JonasGutermuth @n-riesco @booleanbetrayal @Domino987 @ghtmtt @jins-tkomoda @andrefarzat

@andrefarzat
Copy link
Copy Markdown
Contributor

@etpinard it has my ok for the pt-br key 😸

@Domino987
Copy link
Copy Markdown
Contributor

Domino987 commented Aug 26, 2019

@etpinard it has my ok for de, but it would be better to be "Graphen herunterladen". Both work though.

@ghtmtt
Copy link
Copy Markdown
Contributor

ghtmtt commented Aug 27, 2019

@etpinard +1 for Italian too

@fhurta
Copy link
Copy Markdown
Contributor

fhurta commented Aug 27, 2019

@etpinard cs translation is fine

@Batalex
Copy link
Copy Markdown
Contributor Author

Batalex commented Aug 27, 2019

Thanks everyone for your time!

@Domino987 My german is awful, but how do you feel about the "Download plot as a png" just above? Would "Graphen als PNG herunterladen" be better as well?

@Domino987
Copy link
Copy Markdown
Contributor

@Batalex yes that would be better as well.

@tkomde
Copy link
Copy Markdown

tkomde commented Aug 27, 2019

@etpinard ja translation is also fine!

@n-riesco
Copy link
Copy Markdown
Contributor

@etpinard lib/locales/es.js LGTM

@etpinard
Copy link
Copy Markdown
Contributor

Thanks everyone!

We're only missing a 👍 from a sw speaker

@etpinard etpinard added this to the v1.50.0 milestone Sep 6, 2019
@etpinard
Copy link
Copy Markdown
Contributor

Ok, we're still missing a 👍 from a sw speaker, but since the translation appears straightforward

image

I'm ok trusting Deepl here. Merging. Set for release in 1.50.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants