Skip to content

Prevent duplicate renderd sections in renderd.conf#421

Merged
hummeltech merged 1 commit intoopenstreetmap:masterfrom
hummeltech:RenderDPreventDuplicateSections
Mar 25, 2024
Merged

Prevent duplicate renderd sections in renderd.conf#421
hummeltech merged 1 commit intoopenstreetmap:masterfrom
hummeltech:RenderDPreventDuplicateSections

Conversation

@hummeltech
Copy link
Copy Markdown
Collaborator

@hummeltech hummeltech commented Mar 24, 2024

In order to remove any confusion if the user has duplicate renderd sections in their renderd.conf file.

Currently with a configuration like this one:

[renderd]
pid_file=/run/renderd/renderd.pid
socketname=/run/renderd/renderd.sock
stats_file=/run/renderd/renderd.stats
tile_dir=/var/cache/renderd/tiles

[renderd0]
pid_file=/run/renderd/renderd0.pid
socketname=/run/renderd/renderd0.sock
stats_file=/run/renderd/renderd0.stats
tile_dir=/var/cache/renderd/tiles

only the second renderd section (renderd0) will actually be used.

After this patch is merged, an error message will be shown and the application will exit.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.41%. Comparing base (aebb506) to head (13e134c).
⚠️ Report is 51 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   80.40%   80.41%           
=======================================
  Files          24       24           
  Lines        5930     5932    +2     
=======================================
+ Hits         4768     4770    +2     
  Misses       1162     1162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hummeltech hummeltech force-pushed the RenderDPreventDuplicateSections branch from e637788 to 13e134c Compare March 25, 2024 04:05
@hummeltech hummeltech merged commit 7f91d53 into openstreetmap:master Mar 25, 2024
@hummeltech hummeltech deleted the RenderDPreventDuplicateSections branch March 25, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants