Skip to content

Follow up to #190 for render_list#417

Merged
hummeltech merged 5 commits intoopenstreetmap:masterfrom
hummeltech:master
Mar 21, 2024
Merged

Follow up to #190 for render_list#417
hummeltech merged 5 commits intoopenstreetmap:masterfrom
hummeltech:master

Conversation

@hummeltech
Copy link
Copy Markdown
Collaborator

@hummeltech hummeltech commented Mar 21, 2024

  • Fixed render_list build needs libm
  • Added tests
  • Updated man page
  • Created function to set double
  • Cleaned up / optimized a bit
  • Removed --dont-render option

};

int c = getopt_long(argc, argv, "ac:fm:l:X:Y:Z:x:y:z:n:s:t:vhVdA:B:C:D:", long_options, &option_index);
int c = getopt_long(argc, argv, "ac:fm:G:l:W:X:Y:Z:g:w:x:y:z:n:s:t:vhV", long_options, &option_index);

Check warning

Code scanning / Flawfinder

Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20).

buffer/getopt_long:Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20).
fprintf(stderr, "\n");
fprintf(stderr, "If you are using --all, you can restrict the tile range by adding these options:\n");
fprintf(stderr, "(please note that tile coordinates must be positive integers and are not latitude and longitude values)\n");
fprintf(stderr, " -G, --max-lat=LATITUDE maximum latitude\n");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/fprintf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
fprintf(stderr, "If you are using --all, you can restrict the tile range by adding these options:\n");
fprintf(stderr, "(please note that tile coordinates must be positive integers and are not latitude and longitude values)\n");
fprintf(stderr, " -G, --max-lat=LATITUDE maximum latitude\n");
fprintf(stderr, " -g, --min-lat=LATITUDE minimum latitude\n");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/fprintf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
fprintf(stderr, "(please note that tile coordinates must be positive integers and are not latitude and longitude values)\n");
fprintf(stderr, " -G, --max-lat=LATITUDE maximum latitude\n");
fprintf(stderr, " -g, --min-lat=LATITUDE minimum latitude\n");
fprintf(stderr, " -W, --max-lon=LONGITUDE maximum longitude\n");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/fprintf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
fprintf(stderr, " -G, --max-lat=LATITUDE maximum latitude\n");
fprintf(stderr, " -g, --min-lat=LATITUDE minimum latitude\n");
fprintf(stderr, " -W, --max-lon=LONGITUDE maximum longitude\n");
fprintf(stderr, " -w, --min-lon=LONGITUDE minimum longitude\n");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/fprintf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.93%. Comparing base (2a4532f) to head (13cf6d4).
Report is 46 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   79.44%   79.93%   +0.48%     
==========================================
  Files          24       24              
  Lines        5848     5925      +77     
==========================================
+ Hits         4646     4736      +90     
+ Misses       1202     1189      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants