Skip to content

Minor Clean Up of includes and gen_tile.cpp#402

Merged
hummeltech merged 2 commits intoopenstreetmap:masterfrom
hummeltech:RenderThreadStackUsage
Mar 7, 2024
Merged

Minor Clean Up of includes and gen_tile.cpp#402
hummeltech merged 2 commits intoopenstreetmap:masterfrom
hummeltech:RenderThreadStackUsage

Conversation

@hummeltech
Copy link
Copy Markdown
Collaborator

Also:

  • Use mapnik::freetype_engine::register_fonts in gen_tile.cpp rather than recursing manually
    • Available since Mapnik v2 which is no longer supported

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (5014494) to head (29314de).
Report is 59 commits behind head on master.

Files with missing lines Patch % Lines
src/gen_tile.cpp 93.47% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   78.31%   78.29%   -0.03%     
==========================================
  Files          24       24              
  Lines        5866     5851      -15     
==========================================
- Hits         4594     4581      -13     
+ Misses       1272     1270       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hummeltech hummeltech merged commit dd90553 into openstreetmap:master Mar 7, 2024
@hummeltech hummeltech deleted the RenderThreadStackUsage branch March 7, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants