USHIFT-5476: [release-4.19] Fix bug: fix certificate rotation test time mismatch#6444
USHIFT-5476: [release-4.19] Fix bug: fix certificate rotation test time mismatch#6444copejon wants to merge 1 commit intoopenshift:release-4.19from
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@copejon: This pull request references USHIFT-5476 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by ci |
|
@copejon: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| All Certificates Should Be Valid For Current Time | ||
| Setup Kubeconfig | ||
| Wait For MicroShift | ||
| Wait Until Greenboot Health Check Exited |
There was a problem hiding this comment.
The Wait Until Greenboot Health Check Exited keyword will likely exit immediately because the procedure does not change anything for greenboot.
If the intention is to wait for something, we should use Restart Greenboot And Wait For Success instead.
The certificate rotation test changes system time on the remote MicroShift host, but Wait For MicroShift runs oc commands locally on the test runner where time hasn't changed. This causes TLS validation to fail because regenerated certificates have NotBefore set to the future time. Use Wait For MicroShift Healthcheck Success instead, which runs via SSH on the remote host using the manipulated time. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
64f042a to
49d59f3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: copejon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@copejon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Wait For MicroShift(runs oc locally) withWait Until Greenboot Health Check Exited(runs via SSH on remote host)Test plan
🤖 Generated with Claude Code