Convert `value.trim().length() < 1` to `value.isBlank() < 1`

[Pankraz76]

What problem are you trying to solve?

Describe the solution you'd like

Have you considered any alternatives or workarounds?

Additional context

Are you interested in contributing this feature to OpenRewrite?

add recipe to revert these change and apply whats done in the PR:

• Use Collections#isEmpty or String#isEmpty apache/maven#10943
• https://docs.openrewrite.org/recipes/apache/commons/lang/isnotemptytojdk

IsNotEmptyToJdk

    return (value == null) || (value.trim().length() < 1);

    return (value == null) || (value.trim().isEmpty());

[Stephan202]

IIUC (not fully sure) relevant Refaster rules: for Collections, Strings and CharSequences more generally.

[iddeepak]

Just a quick note — replacing s.trim().length() == 0 with s.isBlank() is a great improvement for readability and efficiency.

However, since String#isBlank() was introduced in Java 11, we should make sure the target codebase has Java 11+ as the minimum version before applying this change automatically

[timtebeek]

• Picked up in Introduce StringIsBlank Refaster rule PicnicSupermarket/error-prone-support#1771

We can pick that up here once released; ideally before the end of the week.

[Pankraz76]

Nice thanks. Assuming its gonna be a dedicated recipe like staticanalysis.StringIsBlank, right?

Im wondering if its gonna need custom impl. or just gonna be auto fixed somehow.

Thank, cant wait to integrate this into.

• Introduce Rewrite & PMD covering S1144: Unused "private" methods should be removed opensearch-project/OpenSearch#18791
• Add rewrite support for RemoveUnusedImports elastic/elasticsearch#131611