Description
OpenMLClassificationTask, OpenMLLearningCurveTask in task.py need a refactor. They save information which is already there by inheritance.
Edit.
It seems like the OpenMLLearningCurveTask should extend OpenMLClassificationTask and not OpenMLSupervisedTask.
|
target_name=target_name, |
|
data_splits_url=data_splits_url, |
|
) |
|
self.target_name = target_name |
|
self.class_labels = class_labels |
|
self.cost_matrix = cost_matrix |
|
self.estimation_procedure["data_splits_url"] = data_splits_url |
|
self.split = None |
|
target_name=target_name, |
|
data_splits_url=data_splits_url, |
|
) |
|
self.target_name = target_name |
|
self.class_labels = class_labels |
|
self.cost_matrix = cost_matrix |
|
self.estimation_procedure["data_splits_url"] = data_splits_url |
|
self.split = None |
Description
OpenMLClassificationTask, OpenMLLearningCurveTask in task.py need a refactor. They save information which is already there by inheritance.
Edit.
It seems like the OpenMLLearningCurveTask should extend OpenMLClassificationTask and not OpenMLSupervisedTask.
openml-python/openml/tasks/task.py
Lines 144 to 151 in 7b81dae
openml-python/openml/tasks/task.py
Lines 203 to 210 in 7b81dae