Rename X,y to features, labels

[mfeurer]

As suggested here: #547 (comment)

[PGijsbers]

Hi,
I've been wanting to start helping more again, especially after next week.
This seems like an easy enough issue to jump into. Unless anyone from #547 would prefer to work on it of course :)

To what extent will the renaming go? There are several cases where the X,y naming convention is used:

• local variables in examples (also new one from referenced PR)
• function names
• local variables in functions
• docstrings of said functions

One could leave the function local variables untouched without the end-user ever noticing. But I do favor being consistent myself.

[mfeurer]

Hey, that sounds great. We'll hopefully get #547 merged today or tomorrow, @glemaitre do you think we can get #545 merged quickly afterwards? Then the two biggest PRs would be done and his should be feasible without too many breaking changes. Also, I totally agree that you should strive to rename all variables and not just the public ones.

[glemaitre]

@glemaitre do you think we can get #545 merged quickly afterwards

Yes right after #547. I just need to address the missing point and merge conflict. I actually need the PR to upload some dataset :)

[PGijsbers]

Cool! :) I'll try to keep an eye on it, but a ping here after the merges is appreciated!

[PGijsbers]

I noticed both PRs have been merged, so I will start working on it now.

[PGijsbers]

It seems the development branch is failing unit tests as is. Is there any idea on whether or not this is resolved soon? It seems a little dangerous to make changes and not be able to verify if I broke anything? @mfeurer

[mfeurer]

Hey, yes, the development branch currently has one failing unit test. @janvanrijn promised to fix this throughout the next days (as this requires quite a lot of work). However, it should be safe to ignore this unit test for renaming the attributes.

[PGijsbers]

I'm unassigning myself. I'll happily still do it (when I have time, e.g. in the hackathon), but I figured if someone else (new) wants to pick this up, that is fine too. The idea of me picking this up was so I could get myself familiar with the code again, but that point is moot as I had to get into things for last week's PRs.

[skubatur]

Can I be assigned to this one?

[PGijsbers]

Thanks for wanting to contribute! We wrote contribution guidelines here and if you have any other questions feel free to ask :) Looking forward to your PR.