Skip to content

feat: nms pre-processing#522

Merged
mgumowsk merged 23 commits intomasterfrom
ttybulew/model_requested_postprocessing
Apr 9, 2026
Merged

feat: nms pre-processing#522
mgumowsk merged 23 commits intomasterfrom
ttybulew/model_requested_postprocessing

Conversation

@tybulewicz
Copy link
Copy Markdown
Contributor

@tybulewicz tybulewicz commented Mar 26, 2026 •
edited
Loading

What does this PR do?

Model (or user) may now request Non-maximum Suppression to be executed on detected boxes to select only most meaningful detections.

More flexible way of defining pre-processing steps was dropped due to limited way of model_info section handling in OV.

Fixes #502

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@tybulewicz tybulewicz requested a review from a team as a code owner March 26, 2026 09:19
@tybulewicz tybulewicz changed the title feat: nms processing feat: nms pre-processing Mar 26, 2026
@github-actions github-actions bot added python python related changes docs Related to documentation labels Mar 26, 2026
mgumowsk
mgumowsk reviewed Mar 30, 2026
View reviewed changes
Comment thread src/model_api/models/segmentation.py Outdated
mgumowsk
mgumowsk reviewed Mar 30, 2026
View reviewed changes
Comment thread src/model_api/models/utils.py
mgumowsk
mgumowsk reviewed Mar 30, 2026
View reviewed changes
Comment thread src/model_api/models/parameters.py Outdated
mgumowsk
mgumowsk reviewed Mar 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mgumowsk mgumowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of functionality is added, but there are not unit-tests.

tybulewicz added 22 commits April 9, 2026 09:22
@tybulewicz
Unify output of nms() and multiclass_nms()
be5e4cf
@tybulewicz
Add configurable nms properties
12b615c
@tybulewicz
Fix return type on missing detections
7827d10
@tybulewicz
Run nms only when requested
09c323d
@tybulewicz
multiclass_nms expects expanded arguments
2995c5f
@tybulewicz
nms expects boxes argument
4293cef
@tybulewicz
Unify max_predictions argument name
fa6b3fd
@tybulewicz
Extract nms in Detection models to base class
759c311
@tybulewicz
Calculate nms in detection models
e6be4cb
@tybulewicz
Code style
299f397
@tybulewicz
Allow for no limit in nms
736c3de
@tybulewicz
Rename nms configuration with prefix
6f1449c
@tybulewicz
Add ability to run nms in YOLO models
2dfab55
@tybulewicz
Keep mypy happy
c67f20f
@tybulewicz
NMS parameters added to docs
a631d00
@tybulewicz
NMS docs page
89f1200
@tybulewicz
Restore original name of param
85814c3
@tybulewicz
whitespace reformat
efe4e10
@tybulewicz
remove test files
08cfa27
@tybulewicz
Remove unused NMS params from Segmentation
04e807d
@tybulewicz
Unify nms_max_predictions value
db37716
@tybulewicz
Unify nms return types
2537037
@tybulewicz tybulewicz force-pushed the ttybulew/model_requested_postprocessing branch from 5e01904 to cb90970 Compare April 9, 2026 08:36
@tybulewicz tybulewicz requested a review from mgumowsk April 9, 2026 08:37
@github-actions github-actions bot added the tests Related to tests label Apr 9, 2026
@mgumowsk mgumowsk added this pull request to the merge queue Apr 9, 2026
Merged via the queue into master with commit cc56ecd Apr 9, 2026
31 checks passed
@mgumowsk mgumowsk deleted the ttybulew/model_requested_postprocessing branch April 9, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgumowsk mgumowsk mgumowsk approved these changes

Assignees

No one assigned

Labels

docs Related to documentation python python related changes tests Related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Additional postprocessing

2 participants

@tybulewicz @mgumowsk