Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR normalizes rotated rectangle angles returned by OpenCV's minAreaRect function to ensure consistent angle representation within the (0, 90] degree range. OpenCV's minAreaRect can return angles in different ranges depending on rectangle orientation, which can lead to inconsistent results.
Changes:
- Implemented angle normalization logic that adjusts angles to (0, 90] range by swapping width/height and adding/subtracting 90 degrees as needed
- Updated test reference data to reflect the normalized angle values for rotated rectangles
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/model_api/models/utils.py | Added normalization logic to ensure rotated rectangle angles are in (0, 90] range by adjusting width/height swap and angle offset |
| tests/accuracy/public_scope.json | Updated expected test values to match normalized rotated rectangle representations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mgumowsk
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR normalizes rotated rectangle angles returned by OpenCV's
minAreaRectfunction to ensure consistent angle representation within the (0, 90] degree range. OpenCV'sminAreaRectcan return angles in different ranges depending on rectangle orientation, which can lead to inconsistent results.There was an issue introduced with OpenCV 4.13.0.90 where some rectangles were rotated in a different way then in previous versions, which broke comparisons in tests.
Changes:
Fixes #475
Before submitting