test(extra): fix test failing conditionally on mini's local path#2364
Merged
echasnovski merged 1 commit intonvim-mini:mainfrom Apr 12, 2026
Merged
Conversation
e445cdf to
d56d487
Compare
Details: - When mini.nvim is checked out locally to for example '~/projects/fix_mini', test 'oldfiles-respect local_opts.preserve_order' fails because search key 'x' is now present in all items - Function `validate_spawn_log` is unused and has been removed
d56d487 to
52d77c2
Compare
echasnovski
approved these changes
Apr 12, 2026
Member
echasnovski
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
When mini.nvim is checked out locally to for example '~/projects/fix_mini', test 'oldfiles-respect local_opts.preserve_order' fails because search key 'x' is now present in all items
Function
validate_spawn_logis unused and has been removedThis PR adds the full test path to the test buffers, in order to display only the relative part in the oldfiles picker.
For example, the display of the first item changes from
~/projects/plugins/mini_test_fix_extra/a...intotests/dir-extra/auav.The search keys have been changed from 'xy' into 'uv'(letters not in
tests/dir-extra)I tested a checkout of mini to directory
abcdefghijklmnopqrstuvwxyz0123456789to make sure that there are no other similar failing tests....