Skip to content

fix(arborist): make sure resolveParent exists before checking props#4617

Merged
lukekarrys merged 1 commit intolatestfrom
nlf/fix-update-with-link-dep
Mar 28, 2022
Merged

fix(arborist): make sure resolveParent exists before checking props#4617
lukekarrys merged 1 commit intolatestfrom
nlf/fix-update-with-link-dep

Conversation

@nlf
Copy link
Contributor

@nlf nlf commented Mar 24, 2022

closes #4454

@nlf nlf requested a review from a team as a code owner March 24, 2022 20:53
@npm-robot
Copy link
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 53.042 ±2.03 32.784 ±0.40 31.273 ±16.84 22.223 ±0.40 3.225 ±0.01 3.246 ±0.04 2.706 ±0.12 12.573 ±0.07 2.591 ±0.03 3.646 ±0.01
#4617 53.634 ±1.47 33.852 ±0.72 34.805 ±21.24 23.201 ±1.09 3.426 ±0.13 3.366 ±0.03 2.716 ±0.00 13.028 ±0.14 2.652 ±0.00 3.736 ±0.03
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 37.852 ±0.41 25.788 ±0.27 14.620 ±0.08 15.534 ±0.12 2.990 ±0.01 3.037 ±0.05 2.733 ±0.04 9.529 ±0.18 2.522 ±0.02 3.457 ±0.02
#4617 38.754 ±1.36 26.460 ±0.01 14.783 ±0.07 15.763 ±0.41 2.973 ±0.05 3.024 ±0.03 2.718 ±0.02 9.492 ±0.02 2.476 ±0.01 3.580 ±0.06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] run npm update --save results in error if dependency is defined with file:

4 participants