Skip to content

src: default --icu_case_mapping on as a v8 option#9454

Closed
srl295 wants to merge 1 commit intonodejs:masterfrom
srl295:default_icu_case_mapping
Closed

src: default --icu_case_mapping on as a v8 option#9454
srl295 wants to merge 1 commit intonodejs:masterfrom
srl295:default_icu_case_mapping

Conversation

@srl295
Copy link
Member

@srl295 srl295 commented Nov 3, 2016

  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change
  • toLocaleUpperCase() and toLocaleLowerCase() do not function properly
    without this flag.
  • basic test case. The test case would fail if --no_icu_case_mapping
    was set.

Fixes: #9445

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. i18n-api Issues and PRs related to the i18n implementation. semver-minor PRs that contain new features and should be released in the next minor version. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants