buffer: hard-deprecate calling Buffer without new#8169
Closed
seishun wants to merge 5 commits intonodejs:masterfrom
seishun:new
Closed
buffer: hard-deprecate calling Buffer without new#8169seishun wants to merge 5 commits intonodejs:masterfrom seishun:new
seishun wants to merge 5 commits intonodejs:masterfrom
seishun:new
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
buffer
Description of change
Light version of #7152.
We want to make
Bufferaclassso that it can be subclassed. However, instantiating aclassrequiresnew. This hard-deprecates callingBufferwithoutnew.