util: adhere to noDeprecation set at runtime#6683
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
util: adhere to noDeprecation set at runtime#6683addaleax wants to merge 1 commit intonodejs:masterfrom
noDeprecation set at runtime#6683addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
process (util?)
Description of change
Until now, the docs stated that
process.noDeprecationcould be set at runtime, but before any modules were loaded. That was not true, becauselib/internal/util.jswas loaded during the process startup process, so setting the flag at runtime was always pointless.Minimal test case:
This patch moves checking
process.noDeprecationto the place where it was actually used./cc @jasnell
CI: https://ci.nodejs.org/job/node-test-commit/3263/