debugger: fix stuck debugger when debuggee exits#6332
Closed
reshnm wants to merge 3 commits intonodejs:masterfrom
reshnm:fix_stuck_debugger
Closed
debugger: fix stuck debugger when debuggee exits#6332reshnm wants to merge 3 commits intonodejs:masterfrom reshnm:fix_stuck_debugger
reshnm wants to merge 3 commits intonodejs:masterfrom
reshnm:fix_stuck_debugger
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
debugger
Description of change
Referencing PR #27778
The debuggee node process will never exit because the execution
is blocked inside node::debugger::Agent::Stop,
joining the agent thread.
The debug agent thread is blocked inside uv_run.
To fix this, the debug agent has to close all client connections
in _debug_agent.js (process._debugAPI.onclose).
Additionally all remaining opened handles have to be closed
before calling uv_loop_close.
Otherwise uv_loop_close will fail with UV_EBUSY.
Assume the following script (debug.js):
Calling node debug debug.js produces the following output:
Both
and
exit immediately.