Skip to content

src: fix deadlock in NodePlatform::DrainTasks#62366

Closed
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
geeksilva97:fix-platform-drain-tasks-deadlock
Closed

src: fix deadlock in NodePlatform::DrainTasks#62366
geeksilva97 wants to merge 1 commit intonodejs:mainfrom
geeksilva97:fix-platform-drain-tasks-deadlock

Conversation

@geeksilva97
Copy link
Contributor

Fixes #54918

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 21, 2026
@geeksilva97 geeksilva97 marked this pull request as ready for review March 21, 2026 16:08
@joyeecheung
Copy link
Member

joyeecheung commented Mar 21, 2026

This looks similar to #61963, but as I explained in #61963 (comment) - unless there's a specific reproducible case this can fix, it's not particularly beneficial to introduce a timeout, and it doesn't address the problem 2) in the FIXME (or is making it worse).

@geeksilva97 geeksilva97 requested a review from joyeecheung March 21, 2026 16:08
@geeksilva97 geeksilva97 marked this pull request as draft March 21, 2026 16:12
@codecov
Copy link

codecov bot commented Mar 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (68d7b6f) to head (ffb2f89).
⚠️ Report is 355 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62366      +/-   ##
==========================================
- Coverage   89.77%   89.66%   -0.11%     
==========================================
  Files         673      676       +3     
  Lines      203820   206713    +2893     
  Branches    39175    39590     +415     
==========================================
+ Hits       182987   185359    +2372     
- Misses      13152    13492     +340     
- Partials     7681     7862     +181     
Files with missing lines Coverage Δ
src/node_mutex.h 97.89% <100.00%> (+0.92%) ⬆️
src/node_platform.cc 75.65% <100.00%> (-0.60%) ⬇️
src/node_platform.h 91.66% <ø> (ø)

... and 253 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deadlock at process shutdown

3 participants