quic: remove CryptoKey support from session keys option#62335
Open
panva wants to merge 2 commits intonodejs:mainfrom
Open
quic: remove CryptoKey support from session keys option#62335panva wants to merge 2 commits intonodejs:mainfrom
panva wants to merge 2 commits intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Mar 19, 2026
Member
jasnell
left a comment
There was a problem hiding this comment.
I was hoping we could work towards an API that was not too Node.js-specific but that's something we can address later.
Member
Author
I wouldn't mind (later) but we have make sure to respect the CryptoKey algorithm and usage while doing so. |
Contributor
Failed to start CI- Validating Jenkins credentials ✘ Jenkins credentials invalidhttps://github.com/nodejs/node/actions/runs/23297942276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's not spread any more uses of
CryptoKeyinstances that would ignore its intended use properties such as algorithm and usages.Refs: #55293
Refs: #62321