Skip to content

quic: remove CryptoKey support from session keys option#62335

Open
panva wants to merge 2 commits intonodejs:mainfrom
panva:quic-drop-cryptokey
Open

quic: remove CryptoKey support from session keys option#62335
panva wants to merge 2 commits intonodejs:mainfrom
panva:quic-drop-cryptokey

Conversation

@panva
Copy link
Member

@panva panva commented Mar 19, 2026

Let's not spread any more uses of CryptoKey instances that would ignore its intended use properties such as algorithm and usages.

Refs: #55293
Refs: #62321

@panva panva added the experimental Issues and PRs related to experimental features. label Mar 19, 2026
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Mar 19, 2026
@panva panva requested a review from jasnell March 19, 2026 10:46
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (40c625b) to head (e4d41d4).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62335      +/-   ##
==========================================
- Coverage   89.68%   89.67%   -0.01%     
==========================================
  Files         676      676              
  Lines      206576   206569       -7     
  Branches    39556    39552       -4     
==========================================
- Hits       185266   185245      -21     
- Misses      13445    13450       +5     
- Partials     7865     7874       +9     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)
lib/internal/quic/symbols.js 100.00% <ø> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping we could work towards an API that was not too Node.js-specific but that's something we can address later.

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 19, 2026
@panva
Copy link
Member Author

panva commented Mar 19, 2026

I was hoping we could work towards an API that was not too Node.js-specific but that's something we can address later.

I wouldn't mind (later) but we have make sure to respect the CryptoKey algorithm and usage while doing so.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 19, 2026
@github-actions
Copy link
Contributor

Failed to start CI
- Validating Jenkins credentials
✘  Jenkins credentials invalid
https://github.com/nodejs/node/actions/runs/23297942276

@panva panva removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants