test: split indirect eval import tests#58637
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 11, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split indirect eval import tests as they depend on the JS stack to
resolve the referrer.
These tests can be wonky if the loader internals are changed and performs
microtasks with a JS stack (e.g. with
CallbackScope). In this case, thereferrer will be resolved to the top JS stack frame
node:internal/process/task_queues.js.This is due to the implementation detail of how V8 finds the referrer for a dynamic import
call.