build: fix compatibility with V8's depot_tools#57330
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Mar 7, 2025
Merged
build: fix compatibility with V8's depot_tools#57330nodejs-github-bot merged 1 commit intonodejs:mainfrom
depot_tools#57330nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent changes to
depot_tools'sninja.pyproxy is causing infinite recursion in our V8 CI builds as we checkoutdepot_toolsinto a directory with a leading_(i.e._depot_tools) and the proxy now checks for an exact match (i.e.== "depot_tools") instead ofendswith("depot_tools").Rename our checkout to
depot_tools(without the leading_) so theninja.pyproxy can exclude it when reinvokingninja.Refs: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6259139
Fixes: nodejs/build#4027
cc @nodejs/v8-update @targos