Skip to content

fix require.resolve not considering paths . and .. relative#56735

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
dario-piotrowicz:dario/require-resolve-opts-paths-dot-dot-fix
Jan 25, 2025
Merged

fix require.resolve not considering paths . and .. relative#56735
nodejs-github-bot merged 2 commits intonodejs:mainfrom
dario-piotrowicz:dario/require-resolve-opts-paths-dot-dot-fix

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jan 23, 2025

Fixes: #47000

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas left review comments

@aduh95 aduh95 aduh95 left review comments

@ljharb ljharb ljharb approved these changes

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

+1 more reviewer

@jsumners-nr jsumners-nr jsumners-nr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: require.resolve(".", { paths }) behaves differently from require.resolve("./", { paths })

9 participants

@dario-piotrowicz @nodejs-github-bot @ljharb @aduh95 @mcollina @jasnell @anonrig @legendecas @jsumners-nr