Skip to content

assert: improve partialDeepStrictEqual performance and add benchmark#56555

Closed
puskin wants to merge 1 commit intonodejs:mainfrom
puskin:partial-deep-strict-equal-perf
Closed

assert: improve partialDeepStrictEqual performance and add benchmark#56555
puskin wants to merge 1 commit intonodejs:mainfrom
puskin:partial-deep-strict-equal-perf

Conversation

@puskin
Copy link
Contributor

@puskin puskin commented Jan 10, 2025

now that #54630 has landed, I took the liberty to review the code I wrote to look for improvements that would squeeze some more performance out of the comparison mechanism

  • simplified some logic
  • reviewed loops and introduced more breaking points to make them run for less cycles
  • added a benchmark file to test future possible regressions when it comes to partialDeepStrictEqual

Refs: #54630

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants