doc: add esm examples to node:trace_events#56514
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jan 10, 2025
Merged
doc: add esm examples to node:trace_events#56514nodejs-github-bot merged 1 commit intonodejs:mainfrom
node:trace_events#56514nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
ESMcounterparts of theCJSexamples for the Trace events documentation.I also destructured the (
require) imports for the currentCJSexamples following a feedback I had received in previous PRs, except for the last one where I didn't see it necessary, but tell me what you think and I can do it quickly!I've tested every single example and they all work/behave as expected.
Happy new year! 🥳