Skip to content

doc: fix link in test/README.md#55165

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
LiviaMedeiros:doc-test-common-absolutelink
Sep 30, 2024
Merged

doc: fix link in test/README.md#55165
nodejs-github-bot merged 1 commit intonodejs:mainfrom
LiviaMedeiros:doc-test-common-absolutelink

Conversation

@LiviaMedeiros
Copy link
Member

The relative link points to wrong place when the page is opened as https://github.com/nodejs/node/tree/main/test (without trailing slash nor explicit README.md), because new URL('./common/README.md', 'https://github.com/nodejs/node/tree/main/test').href === 'https://github.com/nodejs/node/tree/main/common/README.md'.

Note that there are similar links in other places (example:

See the json files in [the `status` folder](./status) for prerequisites,
), but they work fine because GitHub resolves them internally to absolute links. I guess it just doesn't touch links in footnotes.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 72 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants