stream: fix isDetachedBuffer validations in ReadableStream#44114
Merged
nodejs-github-bot merged 9 commits intonodejs:mainfrom Aug 18, 2022
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes validations below related to
isDetachedBufferusing a function introduced in #43866.https://streams.spec.whatwg.org/#rs-byob-request-respond
https://streams.spec.whatwg.org/#byob-reader-read
https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue
Refs: #43866 (review)
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com