Skip to content

test: fix multiple incorrect mustNotCall() uses#44022

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
tniessen:test-fix-mustnotcall-usage
Aug 30, 2022
Merged

test: fix multiple incorrect mustNotCall() uses#44022
nodejs-github-bot merged 1 commit intonodejs:mainfrom
tniessen:test-fix-mustnotcall-usage

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jul 28, 2022

This does not fix occurrences in test/parallel/test-dns-* because those tests contain unrelated pre-existing bugs that would cause the tests to fail with this fix. This unrelated bug in those tests should be fixed separately before the use of mustNotCall() can be fixed in those files (see #44428).

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants