Skip to content

net: add drop event for net server#43582

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
theanarkh:add_drop_event_for_net_server
Jul 9, 2022
Merged

net: add drop event for net server#43582
nodejs-github-bot merged 1 commit intonodejs:mainfrom
theanarkh:add_drop_event_for_net_server

Conversation

@theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Jun 26, 2022

add drop event for net server to notify user when the connection is dropped.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected subsystem: net

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@juanarbol juanarbol juanarbol approved these changes

@cjihrig cjihrig Awaiting requested review from cjihrig

@lpinca lpinca Awaiting requested review from lpinca

+1 more reviewer

@F3n67u F3n67u F3n67u left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@theanarkh @nodejs-github-bot @mcollina @ShogunPanda @lpinca @cjihrig @F3n67u @juanarbol @aduh95