Skip to content

build: use ccache in make-v8.sh on ppc64le and s390x#42204

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
richardlau:v8build
Mar 7, 2022
Merged

build: use ccache in make-v8.sh on ppc64le and s390x#42204
nodejs-github-bot merged 1 commit intonodejs:masterfrom
richardlau:v8build

Conversation

@richardlau
Copy link
Member

If ccache is available, use it during V8 builds on ppc64le and s390x.
Only create the gcc and g++ shims if necessary.


Stumbled across https://chromium.googlesource.com/chromium/src/+/HEAD/docs/ccache_mac.md while setting up new RHEL 8 instances on the CI.

I attempted to also enable ccache for the else branch of make-v8.sh, e.g. for Linux x64, but while this did work on the new RHEL 8 x64 CI instance I've been setting up, this fails on test-nearform_intel-ubuntu1604-x64-1 (the machine currently used for label benchmark-ubuntu1604-intel-64 in the job) with lots of errors of this type:

clang++: error: argument unused during compilation:

I figure we can enable this for ppc64le and s390x first and potentially revisit for x64 later on. We've procrastinated over upgrading the benchmark machines (i.e. test-nearform_intel-ubuntu1604-x64-1) from Ubuntu 16.04 for a while (nodejs/build#2656) and this could be another reason to do so.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants