build: use ccache in make-v8.sh on ppc64le and s390x#42204
Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom Mar 7, 2022
Merged
build: use ccache in make-v8.sh on ppc64le and s390x#42204nodejs-github-bot merged 1 commit intonodejs:masterfrom
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
ccacheis available, use it during V8 builds on ppc64le and s390x.Only create the
gccandg++shims if necessary.Stumbled across https://chromium.googlesource.com/chromium/src/+/HEAD/docs/ccache_mac.md while setting up new RHEL 8 instances on the CI.
I attempted to also enable
ccachefor theelsebranch ofmake-v8.sh, e.g. for Linux x64, but while this did work on the new RHEL 8 x64 CI instance I've been setting up, this fails on test-nearform_intel-ubuntu1604-x64-1 (the machine currently used for label benchmark-ubuntu1604-intel-64 in the job) with lots of errors of this type:I figure we can enable this for ppc64le and s390x first and potentially revisit for x64 later on. We've procrastinated over upgrading the benchmark machines (i.e. test-nearform_intel-ubuntu1604-x64-1) from Ubuntu 16.04 for a while (nodejs/build#2656) and this could be another reason to do so.