Skip to content

test: update V8 trace events test expectations#42120

Closed
nickie wants to merge 1 commit intonodejs:masterfrom
nickie:fix-v8-test-trace-events
Closed

test: update V8 trace events test expectations#42120
nickie wants to merge 1 commit intonodejs:masterfrom
nickie:fix-v8-test-trace-events

Conversation

@nickie
Copy link
Contributor

@nickie nickie commented Feb 24, 2022

The event "V8.GCScavenger" is soon to be deprecated. Most of V8 trace events are either behind flags and disabled by default, or are emitted infrequently. Instead of replacing "V8.GCScavenger" with some other random event, this patch updates the tests to check that there is some event in the category "v8" whose name starts with "V8.".

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants