esm: improve validation of resolved URLs#41446
Merged
nodejs-github-bot merged 2 commits intonodejs:masterfrom Jan 19, 2022
Merged
esm: improve validation of resolved URLs#41446nodejs-github-bot merged 2 commits intonodejs:masterfrom
nodejs-github-bot merged 2 commits intonodejs:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ESM internals use type coercion on URL instances to get the href of the URL (ex
`${url}`). This can result in'undefined', which bypasses the current simple "is a string" validation. When that is bypassed, the resulting thrown error is a red herring, pointing to completely unrelated code.Rather than merely switching those internals to use less errant alternatives, I think it's better to improve validation.
cc @nodejs/loaders @nodejs/modules