Skip to content

typings: improve typings#40222

Closed
targos wants to merge 5 commits intonodejs:masterfrom
targos:typings
Closed

typings: improve typings#40222
targos wants to merge 5 commits intonodejs:masterfrom
targos:typings

Conversation

@targos
Copy link
Member

@targos targos commented Sep 26, 2021 

typings: fix declaration of primordials
Closes: https://github.com/nodejs/node/issues/40144

typings: define types for timers binding

typings: add missing types to options and util bindings

typings: define types for os binding

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@tniessen tniessen tniessen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

+2 more reviewers

@Mesteery Mesteery Mesteery left review comments

@evanlucas evanlucas evanlucas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. typings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@targos @jasnell @evanlucas @tniessen @mhdawson @Lxxyx @Mesteery @aduh95 @VoltrexKeyva