Skip to content

build: add library_files to gyp variables#39293

Closed
himself65 wants to merge 1 commit intonodejs:masterfrom
himself65:20210707-support-py3
Closed

build: add library_files to gyp variables#39293
himself65 wants to merge 1 commit intonodejs:masterfrom
himself65:20210707-support-py3

Conversation

@himself65
Copy link
Member

@himself65 himself65 commented Jul 7, 2021

GYP uses the system path when parsing node.gyp; however, if system python is different from our gyp runtime python, like '2.7', gyp would crash.

➜  node git:(master) ./configure && /usr/bin/python3 tools/gyp_node.py -f make 
Node.js configure: Found Python 3.9.6...
INFO: configure completed successfully
Traceback (most recent call last):
  File "tools/search_files.py", line 22, in <module>
    main()
  File "tools/search_files.py", line 19, in main
    print('\n'.join(utils.SearchFiles(options.directory, options.ext)))
  File "/Users/himself65/Code/Github/node/tools/utils.py", line 112, in SearchFiles
    list = glob.glob(dir+ '/**/*.' + ext, recursive=True)
TypeError: glob() got an unexpected keyword argument 'recursive'
gyp: Call to 'python tools/search_files.py --ext js lib' returned exit status 1 while in /Users/himself65/Code/Github/node/node.gyp.

Upstream: #39069

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants