module: fix check for package.json at volume root#34595

Closed

DerekNonGeneric wants to merge 1 commit intonodejs:masterfrom

DerekNonGeneric:fix/root-package-scope

Contributor

DerekNonGeneric commented Aug 1, 2020 •

edited

Loading

This commit converts the "read package scope" algorithm's while loop
into a do-while loop.

Fixes: #33438

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb left review comments

guybedford guybedford left review comments

hybrist hybrist approved these changes

GeoffreyBooth Awaiting requested review from GeoffreyBooth

+1 more reviewer

mmarchini mmarchini approved these changes

Labels

author ready esm module