Skip to content

worker: set trackUnmanagedFds to true by default#34394

Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:worker-track-unmanaged-flip-default
Closed

worker: set trackUnmanagedFds to true by default#34394
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:worker-track-unmanaged-flip-default

Conversation

@addaleax
Copy link
Member

This prevents accidental resource leaks when terminating or exiting
Worker that own FDs opened through fs.open().

Refs: #34303

@nodejs/workers

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-major PRs that contain breaking changes and should be released in the next major version. worker Issues and PRs related to Worker support.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants