Skip to content

[v10.x] deps: V8: backport cd21f71f9cb5#33862

Closed
targos wants to merge 1 commit intonodejs:v10.x-stagingfrom
targos:fix-23142
Closed

[v10.x] deps: V8: backport cd21f71f9cb5#33862
targos wants to merge 1 commit intonodejs:v10.x-stagingfrom
targos:fix-23142

Conversation

@targos
Copy link
Member

@targos targos commented Jun 13, 2020

Original commit message:

[parser] Validate destructuring assignment pattern in correct classifier

Previously we'd first accumulate errors to the parent and validate the
destructuring pattern in the parent. In the case of ParseArguments this
will invalidly propagate binding pattern errors from one argument to the
next. The reason why ParseArguments keeps track of binding pattern errors
is because it could also be used to parse async arrow function parameters.
If we see async(a,b) we don't yet know whether this is the head of an
async arrow function, or a call to async with arguments a and b.

Bug: v8:8241
Change-Id: I670ab9a9c6f2e0bee399808b02a465ae1afa7c3f
Reviewed-on: https://chromium-review.googlesource.com/c/1296229
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56887}

Refs: v8/v8@cd21f71
Fixes: #23142

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants