errors: print original exception context#33491
Closed
bcoe wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --enable-source-maps is set, the error context displayed
above the stack trace now shows original source rather than
transpiled.
When
--enable-source-mapsis set, annotate the top of the stack trace with the original source, rather than the ugly transpiled source:before:
after:
Open questions
The logic in
node_errors.ccis a little magical to me, specifically I'm trying to figure out how it's placing the^under thethrow, rather than under theError(which is where the stack trace points).@addaleax I know you've also worked in this file, any thoughts (maybe this is an issue we don't care about).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes