Skip to content

lib: Add option to disable __proto__ accessors#32279

Merged
devsnek merged 1 commit intonodejs:masterfrom
devsnek:disable-proto
Mar 18, 2020
Merged

lib: Add option to disable __proto__ accessors#32279
devsnek merged 1 commit intonodejs:masterfrom
devsnek:disable-proto

Conversation

@devsnek
Copy link
Member

@devsnek devsnek commented Mar 15, 2020

Adds --disable-proto CLI option which can be set to delete or
throw.

Fixes #31951

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas approved these changes

@guybedford guybedford Awaiting requested review from guybedford

@cjihrig cjihrig Awaiting requested review from cjihrig

@jasnell jasnell Awaiting requested review from jasnell

@mcollina mcollina Awaiting requested review from mcollina

@tniessen tniessen Awaiting requested review from tniessen

+5 more reviewers

@mscdex mscdex mscdex left review comments

@wa-Nadoo wa-Nadoo wa-Nadoo left review comments

@bmeck bmeck bmeck approved these changes

@devnexen devnexen devnexen approved these changes

@vdeturckheim vdeturckheim vdeturckheim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. notable-change PRs with changes that should be highlighted in changelogs. security Issues and PRs related to security. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Disable __proto__